Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dp 13965 change title and h1 #646

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

samseide
Copy link
Contributor

@samseide samseide commented Jun 27, 2019

Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions

Description

Add page header variation for news overflow pages.

Related Issue / Ticket

Steps to Test

  1. Go To: /patterns/03-organisms-by-template-page-header-for-news-overflow/03-organisms-by-template-page-header-for-news-overflow.html
  2. You Should See This: The subheading should be inside the h1 tag

Screenshots

N/A

Additional Notes:

Anything else to add?

Impacted Areas in Application

@todo

Today I learned...

Copy link
Contributor

@ygannett ygannett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Marge is on hold until DP-14191 (Drupal side work) is done.

@ygannett ygannett merged commit 9c42783 into develop Jul 11, 2019
@clairesunstudio clairesunstudio mentioned this pull request Jul 17, 2019
@avrilpearl avrilpearl deleted the feature/DP-13965-change-title-and-H1 branch July 22, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants